Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2362] Fix flaky playwright tests #322

Merged
merged 28 commits into from
Nov 5, 2024
Merged

[ECO-2362] Fix flaky playwright tests #322

merged 28 commits into from
Nov 5, 2024

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Nov 4, 2024

Description

  • Check shadow dom elements by using getByRole
  • Fix some package.json commands that were incorrectly copy-pasted
  • Wait for elements to be visible more explicitly before expecting they are there

Testing

Playwright e2e tests.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:16am
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:16am

@alnoki alnoki added urgency-high Please check first size-small A small PR. This can be reviewed and merged fast. labels Nov 4, 2024
@alnoki alnoki added urgency-medium Check after high urgency and removed urgency-high Please check first labels Nov 4, 2024
Base automatically changed from ECO-2357 to main November 4, 2024 18:22
@xbtmatt
Always add html reporter always
60d5354 
Fix relative path in upload artifact action config
@xbtmatt xbtmatt requested review from alnoki and CRBl69 November 5, 2024 01:20
@alnoki alnoki merged commit 48ee2e8 into main Nov 5, 2024
8 checks passed
@alnoki alnoki deleted the ECO-2362 branch November 5, 2024 01:37
xbtmatt added a commit that referenced this pull request Nov 7, 2024
@xbtmatt
[ECO-2362] Fix flaky playwright tests (#322)
08ef305
xbtmatt added a commit that referenced this pull request Nov 8, 2024
@xbtmatt
[ECO-2362] Fix flaky playwright tests (#322)
fa5ae02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alnoki alnoki alnoki approved these changes

@CRBl69 CRBl69 Awaiting requested review from CRBl69

Assignees
No one assigned
Labels
size-small A small PR. This can be reviewed and merged fast. urgency-medium Check after high urgency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xbtmatt @alnoki